My favorite hero/villian has always been Two Face from the Batman comics. I guess he kind of covers both ends of the spectrum as well

And no, this isn't because I saw "The Dark Knight"... just always been a huge fan of Two Face.

--

If I have to pick classic hero and classic villian?

Classic hero: Indiana Jones was always my favorite hero, but "The Kingdom of the Crystal Skull" pretty much bastardized everything the character stood for.

Classic villian: Patrick Bateman from American Psycho is up there for me. If you want to go really classic then I guess The Emperor from Star Wars would have to top the list, that dude was just evil.